feat(core): patch bazel-skylib for running npm in core #3008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
requested review from
gregmagolan,
mattem and
soldair
as code owners
gregmagolan
approved these changes
Oct 11, 2021
alexeagle
force-pushed
the
tarballs_forever
branch
2 times, most recently
from
ff52766
to
15f5e91
Compare
alexeagle
changed the title
bazelbuild/bazel-skylib#323 is patched into our vendored copy of copy_file rule. That lets an action run with minimal inputs. This is obviously not ergonomic for users yet, just a step in the right direction.
alexeagle
force-pushed
the
tarballs_forever
branch
from
15f5e91
to
d0459bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bazelbuild/bazel-skylib#323 is patched into our vendored copy of copy_file rule.
That lets a tsc action run with just four inputs: [a.ts, bazel-out/host/bin/external/npm_typescript-4.4.3/typescript,
external/bazel_tools/tools/genrule/genrule-setup.sh, external/node16_linux_amd64/bin/nodejs/bin/node]
This is obviously not ergonomic for users yet, just a step in the right direction.